Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(weave): fix small error in EmbeddingSimilarityScorer docs #3289

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

umakrishnaswamy
Copy link

currently it states that EmbeddingSimilarityScorer uses target_column as an argument to the scorer, which is not valid (and raises an error). i made a quick pr to update the docs to include column_mapping

Testing

How was this PR tested?
yarn start

@umakrishnaswamy umakrishnaswamy requested a review from a team as a code owner December 19, 2024 00:43
Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


Uma Krishnaswamy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@circle-job-mirror
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant