Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): replace circle icon #3292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(ui): replace circle icon #3292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .../components/PagePanelComponents/Home/Browse3/pages/CompareEvaluationsPage/ecpConstants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import {MOON_300} from '../../../../../../common/css/color.styles';

export const EVAL_DEF_HEIGHT = 45;
export const STANDARD_PADDING = 16;
export const CIRCLE_SIZE = '16px';
export const BOX_RADIUS = '6px';
export const STANDARD_BORDER = `1px solid ${MOON_300}`;
export const PLOT_HEIGHT = 300;
Expand Down
11 changes: 1 addition & 10 deletions ...ages/CompareEvaluationsPage/sections/ComparisonDefinitionSection/EvaluationDefinition.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import {Box} from '@material-ui/core';
import {Circle} from '@mui/icons-material';
import React, {useMemo} from 'react';

import {
Expand All @@ -14,7 +13,6 @@ import {SmallRef} from '../../../../../Browse2/SmallRef';
import {CallLink, ObjectVersionLink} from '../../../common/Links';
import {useWFHooks} from '../../../wfReactInterface/context';
import {ObjectVersionKey} from '../../../wfReactInterface/wfDataModelHooksInterface';
import {CIRCLE_SIZE} from '../../ecpConstants';
import {EvaluationComparisonState} from '../../ecpState';

export const EvaluationCallLink: React.FC<{
Expand All @@ -33,14 +31,7 @@ export const EvaluationCallLink: React.FC<{
projectName={project}
opName={evaluationCall.name}
callId={props.callId}
icon={
<Circle
sx={{
color: evaluationCall.color,
height: CIRCLE_SIZE,
}}
/>
}
icon={<Icon name="filled-circle" color={evaluationCall.color} />}
color={MOON_800}
/>
);
Expand Down
14 changes: 4 additions & 10 deletions ...se3/pages/CompareEvaluationsPage/sections/ExampleCompareSection/ExampleCompareSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {Box, Tooltip} from '@material-ui/core';
import {Circle, WarningAmberOutlined} from '@mui/icons-material';
import {WarningAmberOutlined} from '@mui/icons-material';
import _ from 'lodash';
import React, {useCallback, useEffect, useMemo, useRef} from 'react';
import styled from 'styled-components';
Expand All @@ -16,6 +16,7 @@ import {
WeaveObjectRef,
} from '../../../../../../../../react';
import {Button} from '../../../../../../../Button';
import {Icon} from '../../../../../../../Icon';
import {CellValue} from '../../../../../Browse2/CellValue';
import {NotApplicable} from '../../../../../Browse2/NotApplicable';
import {SmallRef} from '../../../../../Browse2/SmallRef';
Expand All @@ -31,7 +32,7 @@ import {
DERIVED_SCORER_REF_PLACEHOLDER,
resolvePeerDimension,
} from '../../compositeMetricsUtil';
import {CIRCLE_SIZE, SIGNIFICANT_DIGITS} from '../../ecpConstants';
import {SIGNIFICANT_DIGITS} from '../../ecpConstants';
import {EvaluationComparisonState} from '../../ecpState';
import {MetricDefinition, MetricValueType} from '../../ecpTypes';
import {
Expand Down Expand Up @@ -495,14 +496,7 @@ export const ExampleCompareSection: React.FC<{
projectName={trialProject}
opName={trialOpName}
callId={trialCallId}
icon={
<Circle
sx={{
color: evaluationCall.color,
height: CIRCLE_SIZE,
}}
/>
}
icon={<Icon name="filled-circle" color={evaluationCall.color} />}
color={MOON_800}
/>
</Box>
Expand Down
Loading