chore(weave): Remove temporary n completions #3312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=1744f90f68f818e53740bdec5881d1c38d886235 |
| aws_secret_access_key=aws_secret_access_key, | ||
| aws_region_name=aws_region_name, | ||
| ) | ||
| return tsi.CompletionsCreateRes(response=res.model_dump()) |
There was a problem hiding this comment.
nit: move to else block; only include the specific failure in the try block
andrewtruong
approved these changes
Dec 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hackily implemented n completions for o1 models
We do not need it anymore since litellm/openai now supports
Testing
How was this PR tested?