Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): publish to github packages (#3257) #3388

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

wandbjake
Copy link
Contributor

@wandbjake wandbjake commented Jan 13, 2025

Description

Instead of using the weave-js code directly from the submodule in core, publish @wandb/weave to the github packages npm repo. This will better dedupe dependencies, speed builds, and reduce hacks on the core side.

We publish from the 'src' directory to match the expected layout without doing a whole copying dance.

The version is 0.0.0-sha, and every commit is published. This way we can use the existing sync script for the submodule to also update the node module.

Testing

The standard battery of tests in core pass when using the published version of the package. The mirroring checks in the CI will be broken until the corresponding PR in core merges.

Unreverts #3257

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@wandbjake wandbjake requested a review from a team as a code owner January 13, 2025 18:56
@circle-job-mirror
Copy link

circle-job-mirror bot commented Jan 13, 2025

@wandbjake wandbjake merged commit 49d0da6 into master Jan 13, 2025
124 checks passed
@wandbjake wandbjake deleted the jake/reapply-ghp-1 branch January 13, 2025 21:09
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants