chore(dev): publish to github packages (#3257) #3388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of using the weave-js code directly from the submodule in core, publish @wandb/weave to the github packages npm repo. This will better dedupe dependencies, speed builds, and reduce hacks on the core side.
We publish from the 'src' directory to match the expected layout without doing a whole copying dance.
The version is 0.0.0-sha, and every commit is published. This way we can use the existing sync script for the submodule to also update the node module.
Testing
The standard battery of tests in core pass when using the published version of the package. The mirroring checks in the CI will be broken until the corresponding PR in core merges.
Unreverts #3257