-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(weave): add attributes to langchain integration calls #3521
Conversation
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=85b9c1f2bdb429af4a735b828b6935cb8b70049b |
|
||
|
||
data: {"id":"chatcmpl-9jicpaVkXi2nrE0R4SNVFeCGQ0blB","object":"chat.completion.chunk","created":1720683327,"model":"gpt-3.5-turbo-0125","system_fingerprint":null,"choices":[{"index":0,"delta":{"function_call":{"arguments":"{\""}},"logprobs":null,"finish_reason":null}],"usage":null} | ||
data: {"id":"chatcmpl-Av0tQ435mNvqfk5c4Mtjr8c2ogJPI","object":"chat.completion.chunk","created":1738151492,"model":"gpt-4o-mini-2024-07-18","service_tier":"default","system_fingerprint":"fp_72ed7ab54c","choices":[{"index":0,"delta":{"function_call":{"arguments":"{\""}},"logprobs":null,"finish_reason":null}],"usage":null} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove fingerprints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 removed
@parambharat can you make the CI green and merge this PR. |
@ayulockin, The CI is now 🟢 . But I can't merge the PR since I don't have write access to the repo 🤔 |
WB-22340
Description
This PR enables to attribute tracking in the langchain tracer integration. This simplest way to highlight the fix is the following code snippet. Now we should be able to track the
{"tag": "good_tag"}
attribute in trace op for the the langchain calls.Testing
Included vcr cassette and unit test to verify that the user-added attributes are present in the call attributes.