chore(app): Improve Table column header menu positioning and styling #4012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domphan-wandb
changed the title
domphan-wandb
force-pushed
the
dom/column-menu-design
branch
from
c84a17e to
5f253fe
Compare
domphan-wandb
changed the title
domphan-wandb
force-pushed
the
dom/column-menu-design
branch
4 times, most recently
from
96173f4 to
7657231
Compare
nicholaspun-wandb
approved these changes
Apr 3, 2025
domphan-wandb
force-pushed
the
dom/column-menu-design
branch
2 times, most recently
from
155e073 to
67380e2
Compare
domphan-wandb
force-pushed
the
dom/column-menu-design
branch
from
67380e2 to
c912d15
Compare
onx2
reviewed
Apr 7, 2025
| <ItemIcon | ||
| style={{marginRight: '8px', marginLeft: 0}} | ||
| name={ | ||
| option.icon ?? (selected && option.icon !== null ? 'check' : 'blank') |
There was a problem hiding this comment.
can this be NVM I see what youre doing.selected && option.icon ? 'check' : 'blank'?
Maybe this can be clearer though
Comment on lines
569
to
572
| const handleOpenChange = useCallback((open: boolean) => { | ||
| setMenuOpen(open); | ||
| }, []); | ||
|
|
There was a problem hiding this comment.
useCallback doesn't seem necessary here, have you tested this?
|
Thanks @onx2 ! I updated the PR to address your comments:
|
onx2
approved these changes
Apr 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JIRA: WB-24222
This PR improves the styling of the column action menu:
a. editing actions (edit cell expr)
b. organization actions (group, sort, pin)
c. column manipulation actions (insert, remove)
I had to bring over
weave-js/src/common/components/WBPopupMenuTrigger.tsxfrom wandb/ui (no longer built for app) to update the ordering of the icon and text by passing in an optionRenderer.Design doc used as reference: https://www.notion.so/wandbai/RFC-Query-panels-Table-usability-improvements-Draft-1a4e2f5c7ef380cf8d3fd7c28c51b992?pvs=4
Testing
How was this PR tested?