Update Subtitle.cpp #1155
Open
Update Subtitle.cpp #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For embedded subtitles in video files, skipping produces multiple subtitle objects on the screen make an illusion of repeated subtitles. To prevent this, the changes in above code, accounts for the previous frame and check whether the previous and current text are the same or they differ. If the text differ, it updates the subtitle, if the same, it ignores it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For embedded subtitles in video files, skipping produces multiple subtitle objects on the screen make an illusion of repeated subtitles.
To prevent this, the changes in above code, accounts for the previous frame and check whether the previous and current text are the same or they differ.
If the text differ, it updates the subtitle, if the same, it ignores it.
There might be a better way to fix this, but, this is what i can do currently with my little knowledge on workings of QtAV library.