Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some fixes to MMT code #2

Merged
merged 2 commits into from
Mar 6, 2019
Merged

Conversation

trollcop
Copy link

@trollcop trollcop commented Mar 5, 2019

Heya,

I'm using this to go through some TLV/MMT files and I noticed a bug in the code which skips MPT_descriptors, you do bs.Read(&std::vector) but it's size remains at zero, causing a crash. I guess your sample MMT files didn't have such descriptors, so you didn't notice.

That's commit #1, and second one adds support for --pid to go up to 0xffff (mmt can have PIDs above 1fff since the field is 16bit there). I haven't tested it but it should work.

Anyway, there's some issues still as the

DumpTS.exe input.tlv --srcfmt=mmt --output=output.hevc --outputfmt=es --pid=0xa041

Exits after unsynching with 7F header after few 100kbytes, but that's to be determined with further debugging (my source file should be clean).

@wangf1978
Copy link
Owner

Thanks.

0x1fff is NULL packet for TS stream, it is invalid for MMT.

@wangf1978 wangf1978 merged commit 7b202c3 into wangf1978:master Mar 6, 2019
@trollcop
Copy link
Author

trollcop commented Mar 6, 2019

0x1fff is NULL packet for TS stream, it is invalid for MMT.

Yes, but what I mean is that MMT PIDs are 16bit, where TS PIDs are 12bit. So pid such as 0xa000 is valid for MMT, and --pid should not have been limited to 12-bit.

@wangf1978
Copy link
Owner

Yes, you are right, I have merged your changes. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants