Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya,
I'm using this to go through some TLV/MMT files and I noticed a bug in the code which skips MPT_descriptors, you do bs.Read(&std::vector) but it's size remains at zero, causing a crash. I guess your sample MMT files didn't have such descriptors, so you didn't notice.
That's commit #1, and second one adds support for --pid to go up to 0xffff (mmt can have PIDs above 1fff since the field is 16bit there). I haven't tested it but it should work.
Anyway, there's some issues still as the
DumpTS.exe input.tlv --srcfmt=mmt --output=output.hevc --outputfmt=es --pid=0xa041
Exits after unsynching with 7F header after few 100kbytes, but that's to be determined with further debugging (my source file should be clean).