Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.5.x #13

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

V0.5.x #13

wants to merge 17 commits into from

Conversation

wangtaohz
Copy link
Owner

Why are the changes needed?

(For example: The Arctic Flink dataStream API has already supported this configuration: 'scan.startup.mode', but it is not available with Flink SQL. We should expose this configuration to users when they are using Flink SQL.)

Brief change log

(For example:)

  • Add the 'scan.startup.mode' configuration to the ArcticScanContext in the flink modules
  • The Flink 1.12 and 1.14 versions are affected.
  • Add the documentation in the flink chapter

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants