Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix completed catalog properties #19

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix completed catalog properties #19

wants to merge 3 commits into from

Conversation

wangtaohz
Copy link
Owner

Why are the changes needed?

Close #xxx.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (f1b911b) 51.98% compared to head (2333fc8) 52.03%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #19      +/-   ##
============================================
+ Coverage     51.98%   52.03%   +0.05%     
- Complexity     4094     4097       +3     
============================================
  Files           501      501              
  Lines         28783    28761      -22     
  Branches       2827     2828       +1     
============================================
+ Hits          14963    14966       +3     
+ Misses        12603    12576      -27     
- Partials       1217     1219       +2     
Flag Coverage Δ
core 52.18% <50.70%> (+0.06%) ⬆️
trino 51.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tic/server/catalog/InternalIcebergCatalogImpl.java 89.65% <100.00%> (ø)
.../netease/arctic/server/utils/IcebergTableUtil.java 77.11% <100.00%> (ø)
.../java/com/netease/arctic/CommonUnifiedCatalog.java 33.78% <100.00%> (ø)
...ain/java/com/netease/arctic/mixed/MixedTables.java 93.02% <100.00%> (-0.16%) ⬇️
...m/netease/arctic/hive/catalog/MixedHiveTables.java 86.75% <100.00%> (-0.36%) ⬇️
...netease/arctic/mixed/BasicMixedIcebergCatalog.java 60.00% <0.00%> (ø)
...etease/arctic/server/terminal/TerminalManager.java 20.00% <0.00%> (-0.09%) ⬇️
...n/java/com/netease/arctic/catalog/MixedTables.java 6.87% <0.00%> (+0.24%) ⬆️
...server/dashboard/controller/CatalogController.java 15.13% <0.00%> (+0.08%) ⬆️
.../netease/arctic/catalog/IcebergCatalogWrapper.java 40.45% <60.00%> (+1.64%) ⬆️
... and 2 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants