Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one file driver: add memory efficient chunk read/write unpacking of gzip files #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iasjennen
Copy link

Previously the whole unpacked file was loaded into memory.
This implementation allows to unpack gz files in a streamed way.

@iasjennen
Copy link
Author

btw, the above was tested successfully.
possible implementation for the other two one-file-drivers (untested):

bzip:

    /**
     * @param string $targetPath
     */
    public function streamToFile($targetPath)
    {
        $sfp = bzopen($this->fileName, 'rb');
        $fp = fopen($targetPath, "w");
        while (!feof($sfp)) {
            $chunk = bzread($sfp, 8192);
            if($chunk === 0 || $chunk === false)
                throw new ArchiveExtractionException('Cannot read bzip chunk');
            if(fwrite($fp, $chunk, strlen($chunk)) === false)
                throw new ArchiveExtractionException('Cannot write bzip chunk');
        }
        bzclose($sfp);
        fclose($fp);
    }

lzma:

    /**
     * @param string $targetPath
     */
    public function streamToFile($targetPath)
    {
        $sfp = xzopen($this->fileName, 'rb');
        $fp = fopen($targetPath, "w");
        while (!feof($sfp)) {
            $chunk = xzread($sfp, 8192);
            if($chunk === 0 || $chunk === false)
                throw new ArchiveExtractionException('Cannot read xz chunk');
            if(fwrite($fp, $chunk, strlen($chunk)) === false)
                throw new ArchiveExtractionException('Cannot write xz chunk');
        }
        xzclose($sfp);
        fclose($fp);
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant