Skip to content

Commit

Permalink
bash doesnt run on windows gh actions out of the box, might not be ha…
Browse files Browse the repository at this point in the history
…rd to fix but out of scope right now
  • Loading branch information
wasade committed May 29, 2024
1 parent 9de0831 commit 8bf51ee
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions .github/workflows/python-package-conda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
strategy:
fail-fast: true
matrix:
os: ["ubuntu-latest", "macos-13", "macos-14", "windows-latest"]
os: ["ubuntu-latest", "macos-13", "macos-14"]
python_version: ${{ fromJSON(needs.conf.outputs.supported_pythons) }}
use_conda: [true, false]
steps:
Expand All @@ -69,12 +69,6 @@ jobs:
miniforge-version: ${{ env.miniforge_version }}
miniforge-variant: ${{ env.miniforge_variant }}
environment-file: ci/conda_host_env.yml
- name: Setup for Windows
if: ${{ matrix.os == 'windows-latest' }}
run: |
# Set bash executable explicitly since Make may pick wrong shell
# borrowed from https://github.com/drivendataorg/cookiecutter-data-science/pull/319/files
echo "BASH_EXECUTABLE=$(which bash)" >> "$GITHUB_ENV"
- name: Install dependencies (conda)
if: ${{ matrix.use_conda }}
shell: bash -l {0}
Expand Down

0 comments on commit 8bf51ee

Please sign in to comment.