feat: pagination component [WE-84] #711
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nickb-WaPo
approved these changes
Apr 3, 2025
|
Some failing validations but I know you are taking care of them |
large-frye
reviewed
Apr 3, 2025
| } | ||
|
|
||
| return pagesToShow; | ||
| }; |
There was a problem hiding this comment.
It may be good to set some of these numbers that repeat, such as 5, to a constant. And would these values every change or will always show 1-5 pages?
luciovilla
reviewed
Apr 15, 2025
| css, | ||
| density = "compact", | ||
| icon = "right", | ||
| variant = "secondary", |
There was a problem hiding this comment.
Noticed that the StyledButton that uses this variant prop only uses secondary, so this could be removed and update line 59 to variant="secondary" and the eslint/ts comment issue will go away. Just like in the other component: PaginationNextPageOverflowButton`.
…t/wpds-ui-kit into WE-84-pagination-component
…ected buttons [WE-84]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
https://arcpublishing.atlassian.net/browse/WE-84 -- Pagination Component
Build docs: https://wpds-docs-git-we-84-pagination-component.preview.now.washingtonpost.com/components/Pagination
Storybook: https://wpds-ui-kit-storybook-git-we-84-pagination-component.preview.now.washingtonpost.com/?path=/docs/pagination--docs
Compare against designs: