Update README.md #34
Merged
Update README.md #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the changes I've made locally to get the instructions running :) Signed-off-by: Thomas Gardner <[email protected]>
joonas
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes I've made locally to get the instructions running :)
Feature or Problem
the operator was getting stuck, looking for nats at the default address of nats.default, where as the instructions in the readme have the user setting nats as nats-cluster. This PR brings the nats address inline with the rest of the readme
I have also include the update of the secret name, as again if a user was following the readme the operator would look for a secret named
cluster-secretwhere as the yaml for the secret is setting the name tomy-wasmcloud-clusterRelated Issues
#33
Release Information
Consumer Impact
N/A
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification
These change were apply locally to get the readme working so i could install WASM into Kubernetes for future evaluation