feat: Use wadm-client and wadm-types crates for wadm interactions #38
Conversation
| let wadm_client = | ||
| WadmClient::from_nats_client(&lattice_id, None, watcher.nats_client.clone()); |
There was a problem hiding this comment.
I don't necessarily love this, having to instantiate a new wadm_client::Client each time we reconcile, maybe it should be possible to do something like .set_lattice(...) with the wadm_client::Client to switch between them, since all that currently does is generate different subjects for the various endpoints
There was a problem hiding this comment.
From a code perspective, there really isn't a ton of overhead since it is just storing the nats client (which is a shallow clone) and the lattice string, but if there is an improvement to the client you need, let me know
There was a problem hiding this comment.
Agreed, I thinking it would be nice to store a WadmClient instance instead of the async_nats::Client in the Watcher since it isn't interacting with anything other than wadm in this case, which having the ability to swap between lattices would enable.
I'm not pressed either way, it felt like not having to recreate the WadmClient every time you want to operate on a different lattice could be a nice improvement from usability perspective
joonas
force-pushed
the
feat/use-wadm-client-and-types-crates
branch
from
b97c924 to
ebe0c71
Compare
Signed-off-by: Joonas Bergius <[email protected]>
joonas
force-pushed
the
feat/use-wadm-client-and-types-crates
branch
from
ebe0c71 to
b1d8881
Compare
Feature or Problem
Switching us from using
wash-libto the newly availablewadm-clientandwadm-typescrates instead, which cleans things up nicely!cc @thomastaylor312
Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification