feat!: Remove cluster seed/issuers #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: [`bc5d296`](wasmCloud/wasmCloud@bc5d296) BREAKING CHANGE: Host no longer uses cluster seed as of 1.0. Signed-off-by: Bailey Hayes <[email protected]>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
lxfontes
reviewed
Jul 9, 2024
| @@ -56,7 +56,6 @@ pub struct Context { | |||
|
|
|||
| #[derive(Clone, Default)] | |||
| pub struct Secrets { | |||
| pub wasmcloud_cluster_seed: String, | |||
| pub nats_creds: Option<String>, | |||
There was a problem hiding this comment.
🤔 should this secret be optional in crates/types/src/v1alpha1/wasmcloud_host_config.rs too?
only data left is nats_creds which is already optional.
with no nats creds the secret is basically empty and blocks reconciliation
2024-07-09T15:01:01.575159Z WARN reconciling object{object.ref=WasmCloudHostConfig.v1alpha1.k8s.wasmcloud.dev/my-wasmcloud-cluster.default object.reason=error policy requested retry}: controller::controller: Failed to read secrets: Secret cluster-secrets has no data
There was a problem hiding this comment.
heads up took a stab at it in #68
|
Closing this since #68 was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref:
bc5d296BREAKING CHANGE: Host no longer uses cluster seed as of 1.0.