feat(quickstart): override Redis dependency instead of yaml edit #679
+94
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dreamy-golick-5f201e ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
force-pushed
the
feat/interface-override-quickstart
branch
from
8d9044d to
0735367
Compare
ricochet
reviewed
Nov 8, 2024
|
|
||
| Check the status of the app: | ||
| Once you save `wasmcloud.toml`, we can start our developer loop up again. We'll take a look at the actual change this made to how `wash dev` generated your application later in the tutorial, so we can also output that application manifest to the current directory for later inspection. |
There was a problem hiding this comment.
This paragraph reads a little awkward to me. Suggestions @ericgregory ?
ericgregory
reviewed
Nov 8, 2024
|
|
||
| Check the status of the app: | ||
| Once you save `wasmcloud.toml`, we can start our developer loop up again. We'll take a look at the actual change this made to how `wash dev` generated your application later in the tutorial, so we can also output that application manifest to the current directory for later inspection. |
There was a problem hiding this comment.
Suggested change
| Once you save `wasmcloud.toml`, we can start our developer loop up again. We'll take a look at the actual change this made to how `wash dev` generated your application later in the tutorial, so we can also output that application manifest to the current directory for later inspection. | |
| After saving `wasmcloud.toml`, we'll start our developer loop again. This time, we'll use the `--manifest-output-dir` flag to generate an application manifest in the current directory. (We'll take a look at that file later in the tutorial.) |
ericgregory
reviewed
Nov 8, 2024
| ```shell | ||
| wash app delete hello-world | ||
| ``` | ||
| ## The Application Manifest |
There was a problem hiding this comment.
Suggested change
| ## The Application Manifest | |
| ## The application manifest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR uses interface level overrides to override the keyvalue dependency in the quickstart.
Will depend on wash 0.37 being released, and a newer keyvalue provider version.
Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification