Allow specifying packages with . in their names

this is done by internally replacing all the `.` with `-`.
wasmerio · Feb 12, 2024 · c22e03a · c22e03a
1 parent dcf446e
commit c22e03a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,10 @@ change, where applicable.
 
 ## [Unreleased] - ReleaseDate
 
+- Allow packages with `.` in their names. This is useful for packages
+  `my-website.com`. Internally, the `.` is converted into a `-` to
+  make it a valid binding name.
+
 ### Added
 - Added ability to pass in a user-specified name for the generated
   bindings. This can be done by passing in the `--name` flag in the

diff --git a/crates/wasmer-pack/src/types.rs b/crates/wasmer-pack/src/types.rs
@@ -219,11 +219,10 @@ fn parse_identifier(s: &str) -> Result<String, Error> {
     );
     anyhow::ensure!(
         s.chars()
-            .all(|c| c.is_ascii_alphanumeric() || matches!(c, '-' | '_')),
-        "Identifiers can only contain '-', '_', ascii numbers, and letters"
+        .all(|c| c.is_ascii_alphanumeric() || matches!(c, '-' | '_' | '.')),
+        "Identifiers can only contain '-', '_', '.', ascii numbers, and letters"
     );
-
-    Ok(s.to_string())
+    Ok(s.replace('.', "-"))
 }
 
 /// Information about the [`Package`] being generated.