Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move Runner out of WASIX #4306

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[WIP] Move Runner out of WASIX #4306

wants to merge 5 commits into from

Conversation

syrusakbary
Copy link
Member

@syrusakbary syrusakbary commented Nov 12, 2023

This PR refactors wasmer_wasix by creating a new wasmer_runner package, that has:

  • wasmer_wasix::runtime code
  • wasmer_wasix::http code
  • wasmer_wasix::runner::mode code

At the same time, the implementations should start depending on wasmer_runner, and create runners using the wasmer_runnner::Runner implementation:

  • wasmer_emscripten (move runner out of wasmer_wasix)
  • wasmer_wasix

This PR depends on #4305 to be merged

@syrusakbary
Copy link
Member Author

I'd like to discuss this more before closing, because I think it may make sense to move runners out of WASIX. But still needs discussion

@syrusakbary syrusakbary self-assigned this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant