Upgrade graphql-ws-client to v0.8.0 #4491
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@obmarg thanks for the PR. Do you mind upgrading (tokio-)tungstenite in the other crates as well so we have a single version across the workspace? |
|
@obmarg also note: the failing test is flaky, not caused by your PR. |
|
@theduke done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello wasmer people.
I'm the author of
graphql-ws-client, the library you're using to do GraphQL subscriptions. I've put a bunch of effort into simplifying and improving its API lately. I updated your use of it in this repo as part of my testing effort, so figured I might as well share that update and save you some work - so here it is.