Merge initial support for exception handling validation #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce#1333) * Update the exception-handling validator implementation This commit updates the implementation of the exception-handling proposal to the latest version of the proposal. This was already implemented in the text format but all other crates needed updating. The changes were: * A new `exn` heap type is added for `exnref`. Currently this isn't a subtype with anything else, and this probably isn't correct but it's at least conservative for now. * The `try`, `delegate`, `catch`, `catch_all`, and `rethrow` instructions were all removed as they're no longer present. * New `try_table` and `throw_ref` instructions were added. * Support for the name section subsection for tags has been added along with printing tag names in the text format. * All exception-handling spec tests are now re-enabled. * Update error message * Restore old text format Continue to parse the old exception opcodes both in the text and binary format. Additionally print them too. Don't validate them, however, and additionally don't restore the sugared paren-style parsing of the old text format. This should enable the ability to print out old binaries and reassemble them but will likely render handwritten examples un-workable due to the removal of the parentheses-based form. * No tests need skipping at this time * Fix a bit of mixing old and new syntax
…smfx-merge This patch merges in the initial support for the exception handling validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch merges in the recent change to upstream, which includes the initial support for exception handling validation.