-
-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove user lastActiveTimestamp property #365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems simple enough, approved!
@vincanger You probably did this, but search for lastActiveTimestamp
across the entire repo to ensure there are no leftovers.
@@ -79,7 +79,7 @@ Authorization on the server-side is the core of your access control logic, and d | |||
You can authorize access to server-side operations by adding a check for a logged-in user on the `context.user` object which is passed to all operations in Wasp: | |||
|
|||
```tsx title="src/server/actions.ts" | |||
export const updateCurrentUser: UpdateCurrentUser<...> = async (args, context) => { | |||
export const someServerAction: SomeServerAction<...> = async (args, context) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come we changed this?
@vincanger I double checked. We seem to be missing a doc change and a migration for this. Here's how I did it:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing PR status until we change the docs and add a migration to avoid accidental merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
removes
user.lastActiveTimestamp
property entirely since we're not really using it in a meaningful way.Renames
updateCurrentUser
to a more generic function name in the authorization docs.Contributor Checklist