Updates types

Signed-off-by: Mihovil Ilakovac <[email protected]>
wasp-lang · Aug 18, 2023 · bdac8a0 · bdac8a0
1 parent df44a08
commit bdac8a0
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 11 deletions.
diff --git a/waspc/data/Generator/templates/server/src/auth/providers/email/signup.ts b/waspc/data/Generator/templates/server/src/auth/providers/email/signup.ts
@@ -46,9 +46,9 @@ export function getSignupRoute({
         const additionalFields = validateAndGetAdditionalFields(userFields);
 
         const user = await createUser({
+            ...additionalFields,
             email: userFields.email,
             password: userFields.password,
-            ...additionalFields,
         });
 
         const verificationLink = await createEmailVerificationLink(user, clientRoute);

diff --git a/waspc/data/Generator/templates/server/src/auth/providers/local/signup.ts b/waspc/data/Generator/templates/server/src/auth/providers/local/signup.ts
@@ -9,9 +9,9 @@ export default handleRejection(async (req, res) => {
   const additionalFields = validateAndGetAdditionalFields(userFields)
 
   await createUser({
+    ...additionalFields,
     username: userFields.username,
     password: userFields.password,
-    ...additionalFields,
   })
 
   return res.json({ success: true })

diff --git a/waspc/data/Generator/templates/server/src/auth/providers/types.ts b/waspc/data/Generator/templates/server/src/auth/providers/types.ts
@@ -20,17 +20,27 @@ export type InitData = {
 
 export type RequestWithWasp = Request & { wasp?: { [key: string]: any } }
 
-export function createDefineAdditionalSignupFieldsFn<AlreadyIncludedUserFields extends keyof User>() {
+export function createDefineAdditionalSignupFieldsFn<
+  // Wasp already includes these fields in the signup process
+  ExistingFields extends keyof User,
+  PossibleAdditionalFields = Expand<
+    Partial<Omit<User, ExistingFields>>
+  >
+>() {
   return function defineFields(config: {
-    [key in keyof Partial<Omit<User, AlreadyIncludedUserFields>>]: FieldDefinition<Partial<Omit<User, AlreadyIncludedUserFields>>[key]>
+    [key in keyof PossibleAdditionalFields]: FieldDefinition<
+      PossibleAdditionalFields[key]
+    >
   }) {
     return config
   }
 }
 
 type FieldDefinition<T> = {
-  get: (data: Partial<{
-    [key in keyof User]: unknown
-  }>) => T | undefined;
-  validate: (value: T | undefined) => void;
+  get: (
+    data: Partial<{
+      [key in keyof User]: unknown
+    }>
+  ) => T | undefined
+  validate: (value: T | undefined) => void
 }
diff --git a/waspc/data/Generator/templates/server/src/auth/utils.ts b/waspc/data/Generator/templates/server/src/auth/utils.ts
@@ -16,12 +16,14 @@ import { Email } from '../email/core/types.js';
 {=& additionalSignupFieldsFn.importStatement =}
 {=/ additionalSignupFieldsFn.isDefined =}
 
-
 {=# additionalSignupFieldsFn.isDefined =}
 const _waspAdditionalSignupFieldsConfig = {= additionalSignupFieldsFn.importIdentifier =}
 {=/ additionalSignupFieldsFn.isDefined =}
 {=^ additionalSignupFieldsFn.isDefined =}
-const _waspAdditionalSignupFieldsConfig = {}
+import { createDefineAdditionalSignupFieldsFn } from './providers/types.js'
+const _waspAdditionalSignupFieldsConfig = {} as ReturnType<
+  ReturnType<typeof createDefineAdditionalSignupFieldsFn<never>>
+>
 {=/ additionalSignupFieldsFn.isDefined =}
 
 type {= userEntityUpper =}Id = {= userEntityUpper =}['id']

diff --git a/...xamples/todoApp/src/server/auth/signup.js → ...xamples/todoApp/src/server/auth/signup.ts b/...xamples/todoApp/src/server/auth/signup.js → ...xamples/todoApp/src/server/auth/signup.ts
@@ -2,7 +2,7 @@ import { defineAdditionalSignupFields } from '@wasp/types/index.js'
 
 export const fields = defineAdditionalSignupFields({
   address: {
-    get: (data) => data.address,
+    get: (data) => data.address as string | undefined,
     validate: (value) => {
       if (!value || value.length < 5) {
         throw new Error('Address is required')