Controller implementation: freertos #116
Open
+139
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 8, 2025
This was
unlinked from
issues
Feb 8, 2025
celery6
requested changes
Feb 9, 2025
…try/cansw_processor_canards into controller-implementation
Joe-Joe-Joe-Joe
requested changes
Feb 11, 2025
| log_text("controller", "flight phase changed"); | ||
| } | ||
|
|
||
| #if current_phase == STATE_ACT_ALLOWED || current_phase == STATE_COAST // if is proper state |
There was a problem hiding this comment.
Please read https://gcc.gnu.org/onlinedocs/cpp/Conditionals.html in detail
| * @return W_FAILURE if validation/queueing fails | ||
| */ | ||
| w_status_t controller_update_inputs(controller_input_t *new_state) { | ||
| if (xQueueOverwrite(internal_state_queue, new_state) == pdPASS) { // overwrite internal queue |
There was a problem hiding this comment.
xQueueOverwrite can only ever return pdPASS so this error checking is ineffective
https://www.freertos.org/Documentation/02-Kernel/04-API-references/06-Queues/11-xQueueOverwrite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.