MCAS w/generic crystallizer

[adam-a-a]

Fixes/Resolves:

Summary/Motivation:

Building on @OOAmusat 's work on a generic crystallizer by making it compatible with MCAS and also revising to match more closely with IDAES/WaterTAP standards.

Changes proposed in this PR:

• add enthalpy and pressure_sat relationships for seawater into MCAS
• remove unnecessary inclusions related to properties or ion sets from crystallizer model and point to prop pack
• general code cleanup
• update mcas documentation

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

[adam-a-a]

I am thinking about bringing this back as a method of the unit model...

[OOAmusat]

The question is whether we want to do that, or allow the user to define their own function entirely.

I don't think it should be in the unit model file. However, we could support rbfs and maybe even NN models as defaults. We could have the code in a different file that the user can load as the default with optional arguments.

[adam-a-a]

That was what I was thinking--something along the lines of calling the method on the unit model to build some surrogate(s). And defaults could sit in our data folder with a new directory for default_surrogates or something like that. Either way, I don't love the idea of it living in this test file or in some future example flowsheet file.

[OOAmusat]

The question is whether we want to do that, or allow the user to define their own function entirely.

I don't think it should be in the unit model file. However, we could support rbfs and maybe even NN models as defaults. We could have the code in a different file that the user can load as the default with optional arguments.

[kurbansitterley]

@adam-a-a are you only planning on making the surrogate compatible with MCAS or also the physical model?

[adam-a-a]

@ElmiraShamlou I can add pressure_sat to MCAS. In that case though, it sounds like we should relate pressure_sat to pressure_operating in the surrogate_crystallizer.

[adam-a-a]

I suppose in this case, pressure_operating relates to the surrogate output, so perhaps not. I'd welcome feedback though. Maybe it is enough to just add pressure_sat to MCAS.

[ElmiraShamlou]

@ElmiraShamlou I can add pressure_sat to MCAS. In that case though, it sounds like we should relate pressure_sat to pressure_operating in the surrogate_crystallizer.

@adam-a-a Yes, this is necessary when the surrogate vapor pressure output is unavailable for a generic surrogate. It can be added as needed, using a custom constraint (like blk.pressure_conversion_constraints in the test file), which ties the operating pressure to the saturation pressure. Alternatively, this could be implemented as a config option, with the property package’s saturation vapor pressure set as the default when the surrogate option is not selected.

[ElmiraShamlou]

I suppose in this case, pressure_operating relates to the surrogate output, so perhaps not. I'd welcome feedback though. Maybe it is enough to just add pressure_sat to MCAS.

Yes, it is not required for this specific PR.

[adam-a-a]

@ElmiraShamlou That was a good point to bring up though. @OOAmusat is going to put up a PR that adds the reaktoro capability in place of surrogates. I was about to revise the surrogate_crystallizer config options but remembered that we decided to wait on making more changes until after Mayo's upcoming PR. From there, I think we can arrive at a revision that would accommodate the different forms this model can take (e.g., using prop model pressure sat, using surrogate, using reaktoro block, etc.).

[ElmiraShamlou]

Great job!