Skip to content

Fix imports and flake8 failures #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: speed-up-index-creation-move-inside-create-table
Choose a base branch
from
Open

Fix imports and flake8 failures #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions sqlalchemy_cockroachdb/ddl_compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,15 @@
import re

from sqlalchemy import exc
from sqlalchemy.dialects.postgresql.base import PGDDLCompiler
from collections.abc import Sequence
from typing import Any, cast

from sqlalchemy import ColumnElement, exc
from sqlalchemy import ColumnElement
from sqlalchemy.ext.compiler import compiles # type: ignore[import-untyped]
from sqlalchemy.schema import CreateIndex, CreateTable, Index, Table
from sqlalchemy.sql import coercions, expression, roles
from sqlalchemy.sql.compiler import DDLCompiler # type: ignore[import-untyped]
from sqlalchemy_cockroachdb.base import ( # type: ignore[import-untyped]
CockroachDBDialect,
)
from sqlalchemy_cockroachdb.ddl_compiler import ( # type: ignore[import-untyped]
CockroachDDLCompiler,
)


class CockroachDDLCompiler(PGDDLCompiler):
Expand Down Expand Up @@ -70,7 +66,7 @@ def visit_create_index(element: Any, compiler: CockroachDDLCompiler, **kw: Any)
was_created = index.info.get("_cockroachdb_index_created_by_create_table", False)
assert was_created

return "SELECT 'No-op: in cockroachdb we put index creation DDL inside the corresponding CREATE TABLE for improved performance.'"
return "SELECT 'No-op: in cockroachdb we put index creation DDL inside the corresponding CREATE TABLE for improved performance.'" # noqa


# Copy+paste of private function DDLCompiler._prepared_index_name
Expand Down Expand Up @@ -122,7 +118,7 @@ def _codegen_index(
if index.name is None:
raise exc.CompileError("CREATE INDEX requires that the index have a name")

text += "INDEX %s " % _prepared_index_name(
text += "\tINDEX %s " % _prepared_index_name(
index, compiler, include_schema=include_schema
)

Expand Down