This repository has been archived by the owner on Apr 24, 2018. It is now read-only.
remove jQuery #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a DOM-like event system so that we'd still can use jQuery on the install object. This need to be verified though.
|
With jQuery removed, we could then remove also the require dependency. |
|
ok, jQuery seems to like these addEventListener and co. Good news ! I tried both 1.9.0 and 1.6.4. |
|
I am hoping to clean up some things for an fx app hack day coming this Saturday, and I want to address this before then. I may go with a slightly different approach, but use a smaller shim for this functionality. But I will know more later in the week. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a DOM-like event system so that we'd still can
use jQuery on the install object.
This need to be verified though.
I didn't actually try to use this so I'm pretty sure this won't be perfect ;) Still this is jshint-error free. The only thing I really don't know is if jQuery will accept to listen on events on this object that is not a Node even if it implements
addEventListenerand other such functions.As a side node, I'm not sure we should expose dispatchEvent too.