Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use libwaysip instead of slurp #152

Merged
merged 3 commits into from
Mar 26, 2025

Conversation

Decodetalkers
Copy link
Collaborator

@Decodetalkers Decodetalkers commented Mar 24, 2025

resolve: #1

@Shinyzenith
Copy link
Member

What is the type FreezeFun and can we possibly have a better name for it?

@Decodetalkers
Copy link
Collaborator Author

What is the type FreezeFun and can we possibly have a better name for it?

It is just a name, describing the fun inside the enum, because clippy thought this type is too long, so I split it. Can you give me a better name? Thanks

@Shinyzenith
Copy link
Member

FreezeCallback sounds perfect

Shinyzenith
Shinyzenith previously approved these changes Mar 24, 2025
@Shinyzenith
Copy link
Member

Before merging we also need to do some documentation changes, I'll do that

@Shinyzenith
Copy link
Member

We're also going to need support for passing waysip args just how we pass slurp args

@Shinyzenith
Copy link
Member

Now that config file pr is merged, all relevant documentation places need to be changed

@Decodetalkers
Copy link
Collaborator Author

Now that config file pr is merged, all relevant documentation places need to be changed

rebase done

@Shinyzenith
Copy link
Member

Looks mostly good, just one doubt, don't we need to remove support for SLURP_ARGS from config file? @Decodetalkers

@Decodetalkers
Copy link
Collaborator Author

Looks mostly good, just one doubt, don't we need to remove support for SLURP_ARGS from config file? @Decodetalkers

Ha..yes , I have forgotten that, can you fix that for me? Thanks

@Shinyzenith
Copy link
Member

Sounds good, I'll do it

@Shinyzenith
Copy link
Member

Oh it seems like config file already doesn't accept SLURP_ARGS and that makes sense because that's supposed to be part of invocation. It's not meant to be present all the time.

@Shinyzenith Shinyzenith merged commit 586ee25 into waycrate:main Mar 26, 2025
4 checks passed
@Decodetalkers Decodetalkers deleted the libwaysip branch March 26, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Remove slurp as a dependency, aka fork slurp to rust.
2 participants