Support for Payment Service API endpoint #466
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Wrapper methods for Payment Service API
2. Attach Payment Service to Branding Theme via the endpoints below:
- GET /BrandingThemes/{BrandingThemeID}/PaymentServices
- POST /BrandingThemes/{BrandingThemeID}/PaymentServices
|
With the current implementation, I have to parse the XML by myself. It also diverges from the existing syntax and structure of the gem where the code to add associations rests in the parent and is shared by including the @waynerobinson @CloCkWeRX Would like both your inputs on this implementation. TODO Add test cases for the above code change. Planning to do it once I receive your feedback. |
CloCkWeRX
reviewed
Apr 18, 2019
| }.to_xml | ||
|
|
||
| @application.http_post(@application.client, payment_services_endpoint(id), xml) | ||
| module Extensions |
There was a problem hiding this comment.
Given the namespace change, can you update the CHANGELOG as well / write some quick migration notes?
|
I will write release notes for this and include it in the gem release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a. GET /BrandingThemes/{BrandingThemeID}/PaymentServices
b. POST /BrandingThemes/{BrandingThemeID}/PaymentServices
Xeroizer::Recordobjects for Branding Theme as well as Payment Service API response.