Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font size correction in table #6987

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Sep 11, 2024

Description

Font size correction in table

Issues Resolved

#6986

Evidence

image image image image image image image image image image image image image image

Test

  • Verify in the Threat Hunting dashboard table that the font size for all fields and their displayed results is 13px.

  • Verify in the events tab table of each module that the font size for all fields and their displayed results is 13px.

  • Verify in the table of the inventory tab of the Vulnerabilities module that the font size for all fields and their displayed results is 13px.

  • Test it with different rule.gdpr values (single value, multiple gdpr's, no value).

image

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm self-assigned this Sep 11, 2024
Tostti
Tostti previously approved these changes Sep 11, 2024
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟢
image
image

CR 🟢

LGTM

@guidomodarelli
Copy link
Contributor

guidomodarelli commented Sep 11, 2024

CR 🟢
Test 🟢

image
image
image

guidomodarelli
guidomodarelli previously approved these changes Sep 11, 2024
@asteriscos asteriscos dismissed stale reviews from guidomodarelli and Tostti via 2b3cfd2 September 16, 2024 11:31
@guidomodarelli
Copy link
Contributor

guidomodarelli commented Sep 16, 2024

CR 🟢
Test 🟢

image

image

image

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 46.02% ( 400 / 869 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.22% ( 398 / 861 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.75% ( 4069 / 29588 )
Branches 9.13% ( 1765 / 19314 )
Functions 13.45% ( 959 / 7130 )
Lines 13.92% ( 3965 / 28468 )

@asteriscos asteriscos merged commit b8bf9d1 into 4.9.1 Sep 17, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/6986-threat-hunting-dashboard-mismatch-between-alert-fonts-in-the-events-section branch September 17, 2024 10:56
@asteriscos asteriscos mentioned this pull request Oct 2, 2024
17 tasks
@guidomodarelli guidomodarelli linked an issue Oct 3, 2024 that may be closed by this pull request
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the events page Threat Hunting dashboard - Mismatch between alert fonts in the events section
5 participants