Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dev environment script #7172

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Nov 22, 2024

Description

This issue aims to improve the osd-dev script by adding:

  • Take OpenSearch and OpenSearch dashboard versions from packages.json in core-plugin
  • Add a flag to the script to manually add OpenSearch and OpenSearch dashboard versions
  • Add a manage to imposter version in dev.sh
  • Improve terminal response from script

Issues Resolved

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Nov 22, 2024
yenienserrano
yenienserrano previously approved these changes Nov 22, 2024
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Wazuh Fleet plugin code coverage (Jest) test % values
Statements 4.68% ( 9 / 192 )
Branches 16.66% ( 7 / 42 )
Functions 1.11% ( 1 / 90 )
Lines 4.76% ( 9 / 189 )

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 46.02% ( 400 / 869 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.22% ( 398 / 861 )

Copy link
Contributor

Wazuh Engine plugin code coverage (Jest) test % values
Statements 8.63% ( 64 / 741 )
Branches 7.94% ( 22 / 277 )
Functions 1.87% ( 7 / 373 )
Lines 9.1% ( 64 / 703 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.43% ( 4027 / 29984 )
Branches 8.96% ( 1749 / 19516 )
Functions 12.98% ( 944 / 7270 )
Lines 13.59% ( 3925 / 28861 )

@asteriscos asteriscos merged commit 5f6bf65 into master Nov 22, 2024
7 checks passed
@asteriscos asteriscos deleted the change/6962-improve-script-for-dev-environment branch November 22, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants