Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore specific branches in ESLint workflow and simplify yarn commands #7186

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Ignore specific branches in ESLint workflow and simplify yarn commands #7186

merged 2 commits into from
Dec 11, 2024

Conversation

guidomodarelli
Copy link
Contributor

@guidomodarelli guidomodarelli commented Dec 2, 2024 •
edited by Desvelao
Loading

Description

Ignore specific branches in ESLint workflow and simplify yarn commands

Issues Resolved

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

yenienserrano
yenienserrano approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guidomodarelli guidomodarelli self-assigned this Dec 10, 2024
@guidomodarelli guidomodarelli added the request/operational Operational requests label Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.92% ( 4445 / 29774 )
Branches 9.77% ( 1877 / 19206 )
Functions 14.68% ( 1057 / 7200 )
Lines 15.14% ( 4339 / 28646 )

Desvelao
Desvelao approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desvelao Desvelao merged commit af71101 into 4.10.0 Dec 11, 2024
5 checks passed
@Desvelao Desvelao deleted the change/modify-config-eslint-workflow branch December 11, 2024 10:21
@asteriscos asteriscos removed the request/operational Operational requests label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@Desvelao Desvelao Desvelao approved these changes

Assignees

@guidomodarelli guidomodarelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guidomodarelli @Desvelao @yenienserrano @asteriscos