forked from opensearch-project/OpenSearch
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make command.action.args
type object
instead of keyword
type value
#630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generating the mapping:(env) fede@tyner:~/src/ecs ((ce2e1da5...))
$ ./generate.sh v8.11.0 ~/src/wazuh-indexer command
Loading schemas from git ref v8.11.0
Running generator. ECS version 8.11.0
Loading user defined schemas: ['/home/fede/src/wazuh-indexer/ecs/command/fields/custom/']
Replacing "constant_keyword" type with "keyword"
Replacing "wildcard" type with "keyword"
Replacing "match_only_text" type with "keyword"
Replacing "flattened" type with "flat_object"
Replacing "scaled_float" type with "float"
Removing scaling_factor lines
Deleting the "tags" field from the index template
Removing multi-fields from the index template
Mappings saved to /home/fede/src/wazuh-indexer/ecs/command/mappings/v8.11.0
|
AlexRuiz7
requested changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some things missing in order to consider the issue ready to review. Refer to the Plan described in the issue.
- Update index model and documentation.
- Update index template on the setup plugin and tooling.
- Update Management API commands (orders) schema.
- Update Agent commands (orders) schema.
QU3B1M
approved these changes
Jan 10, 2025
AlexRuiz7
approved these changes
Jan 10, 2025
AlexRuiz7
approved these changes
Jan 10, 2025
f-galland
added a commit
that referenced
this pull request
Feb 20, 2025
…lue (#630) * Make command.action.args an object instead of a keyword value * Update description and dynamic setting * Updating event_generator.py * Update command.action.args description --------- Co-authored-by: Álex Ruiz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
command.action.args
from the.commands
index template from keyword intoobject
to accommodate for various data types, including arrays.Related Issues
Resolves #618
Check List