Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic for xfail test in api performance test #4657

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Fix logic for xfail test in api performance test #4657

merged 4 commits into from
Nov 29, 2023

Conversation

RamosFe
Copy link
Member

@RamosFe RamosFe commented Oct 27, 2023

Related issue
#3665

Description

Added logic to API Performance test to check if a test case marked as xfailed ran correctly.

@RamosFe RamosFe self-assigned this Oct 27, 2023
@RamosFe RamosFe linked an issue Oct 27, 2023 that may be closed by this pull request
Improve xfailed management in API performance tests #3665
Closed
@RamosFe RamosFe changed the title Changes logic for xfail test in api performance test Fix logic for xfail test in api performance test Oct 27, 2023
@RamosFe RamosFe force-pushed the fix/3665-xfailed-test-performance branch from de1de8b to 4f995c2 Compare October 27, 2023 20:02
@RamosFe RamosFe force-pushed the fix/3665-xfailed-test-performance branch from 4f995c2 to 425c81e Compare October 27, 2023 20:05
@RamosFe
Copy link
Member Author

RamosFe commented Oct 27, 2023

Update

The changelog wasn't updated because this Issue doesn't have an assigned Release.

GGP1
GGP1 requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@GGP1 GGP1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog should be added to the latest available version if no release is assigned to the issue.

Also, we are requested by QA to include the test logs of three consecutive executions, so please add them to the pull request description.

tests/performance/test_api/test_api_endpoints_performance.py Outdated Show resolved Hide resolved
@RamosFe
Copy link
Member Author

RamosFe commented Nov 23, 2023

Update

Changed the logic of the test to the endpoints and then marked them as xfail if failed. If it does not fail, print a warning.

Executions Results

TestRunsTerminal.txt
Reports.zip

The changelog wasn't changed in the commits due to the Issue not having a release specified.

@GGP1 GGP1 self-requested a review November 24, 2023 12:30
GGP1
GGP1 previously approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@GGP1 GGP1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Selutario
Selutario suggested changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@Selutario Selutario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, add the changelog entry for 4.9.0 (since this is targeting master branch)

@RamosFe RamosFe force-pushed the fix/3665-xfailed-test-performance branch from a61bd25 to 38ba833 Compare November 24, 2023 21:01
@RamosFe
Copy link
Member Author

RamosFe commented Nov 24, 2023

Fixed typo in commit 38ba833.

@RamosFe RamosFe force-pushed the fix/3665-xfailed-test-performance branch from 38ba833 to 0584c3a Compare November 24, 2023 21:30
Selutario
Selutario suggested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@Selutario Selutario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the QA team updated the changelog and there are some conflicts that need to be fixed before merging.

@davidjiglesias davidjiglesias merged commit 0354328 into master Nov 29, 2023
5 checks passed
@davidjiglesias davidjiglesias deleted the fix/3665-xfailed-test-performance branch November 29, 2023 12:01
@rauldpm rauldpm restored the fix/3665-xfailed-test-performance branch September 4, 2024 19:21
@rauldpm rauldpm deleted the fix/3665-xfailed-test-performance branch September 4, 2024 19:21
@sebasfalcone sebasfalcone mentioned this pull request Sep 4, 2024
Closed
@Rebits Rebits mentioned this pull request Sep 5, 2024
Closed
3 tasks
@GGP1 GGP1 mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidjiglesias davidjiglesias davidjiglesias approved these changes

@Selutario Selutario Selutario approved these changes

@GGP1 GGP1 GGP1 left review comments

Assignees

@RamosFe RamosFe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve xfailed management in API performance tests
4 participants
@RamosFe @Selutario @davidjiglesias @GGP1