Fix ssl connection #178
Merged
Fix ssl connection #178
+84
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbarnha
requested changes
Apr 10, 2024
|
Besides the aforementioned change I've suggested, everything else here I agree with. Thanks a bunch, I'm looking forward to getting this merged. |
wbarnha
reviewed
Apr 10, 2024
wbarnha
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #177
For SSL protocol, the socket will be wrapped inside a SSLSocket instance, and the original socket will be detached, i.e., closed without closing the underlying file description. This leads to -1 socket.fileno inside Epoll selector.
This does not create any problem until #156 , which unregisters fd based on socket.fileno.
We can just check
key.fdinstead ofkey.fileob.fileno()on top of #156, but I think a better solution is to handle SSL socket more gracefully. Having a registered socket withkey.fd != key.fileobj.fileno()is error-prone in my opinion.