Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a minor mode #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added a minor mode #4

wants to merge 1 commit into from

Conversation

AndreaOrru
Copy link

@AndreaOrru AndreaOrru commented May 18, 2020

When enabled, it sets the checker to python-coverage, and changes the style of flycheck.
When disabled, restores flycheck's previous checker and style.

This is how it looks like:
image

@@ -469,5 +469,39 @@ The EVENT causes the overlays in BUFFER to get refreshed."

(add-to-list 'flycheck-checkers 'python-coverage t))

(after 'python-coverage
(define-minor-mode python-coverage-mode
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is highly flycheck specific, lets name this python-coverage-flycheck-mode instead. (same in if below)

@wbolster
Copy link
Owner

hey, thanks for your contribution. i totally forgot about this. i left a small remark.

@wbolster wbolster self-assigned this Sep 28, 2021
@wbolster wbolster added the enhancement New feature or request label Sep 28, 2021
@wbolster
Copy link
Owner

btw have you tried python-coverage-overlay-mode? apart from navigation using flycheck, how is this different?

@wbolster wbolster force-pushed the master branch 4 times, most recently from ca94739 to 5d47f38 Compare December 6, 2021 16:40
@ryukinix
Copy link

I liked that idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants