-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A collection of useful Sublime Text snippets for React Development #9003
base: master
Are you sure you want to change the base?
Conversation
We have over a dozen snippets packages for React. I'm sure all are better than everything else and simplify development. Why would a user consider installing yours over, or in addition, everything else? If it's a set of mostly generic snippet, consider contributing to an existing package like https://packagecontrol.io/packages/ReactJS%20Snippets |
@braver I guess I just couldn't find the one among many existing ones that I'd use for myself (or could extend with Redux Toolkit things and all, yet keeping it simple and free of redundancy). But I got your point, thanks for the feedback! |
I'm open to considering publishing your package as a direct replacement of https://packagecontrol.io/packages/ReactJS%20Snippets. That one has exactly one, 12 years old, snippet. |
That'd be great! I tried to create the most up-to-date thing that gathers all react/js/redux most used commands in one place. There will be defiantly more use than one 12 years old snippet :) |
Co-authored-by: Koen Lageveen <[email protected]>
@braver committed! |
@HelloXiuXiu don't forget to remove the |
removing 12yo https://github.com/saada/reactjs-snippets package to replace with a new one
@braver done ✅ |
@braver should I create an npm package too? Or it's an independent process not related to my current submission? (sorry if the question is dumb, it's my first contribution) |
Please have a look at the output from the bot. Looks like duplicate labels and an issue with inconsistent indentation? Also, please remove package-control.json from your repo, all the metadata for package control are in this repo. NPM isn't involved in any of this. With the entry in the repository via this PR, package control knows enough to deliver packages to users of Sublime Text. You do still need to tag a semver-correct release on your repo. Any time you make any changes, tag them, and package control will deliver it to users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Packages modified:
- React + Js Snippets
Looking good! Protocol now is to let this sit for 2 weeks to give the author of the package we’re removing to object. Assuming they don’t, we’ll merge it then. |
@braver great, thanks for your help! One last question: I've made a few minor changes to the package after I'd opened this PR. Should I start with v1.0.0 anyway? |
You can number your release any way you like as long as it’s three numbers. You can start with 77.95.99 if that makes sense to you 😄 |
My package is a collection of useful Sublime Text snippets for React.
It's similar to "React Development Snippets", However it should still be added because it's more modern and simplified version that can simplify React development.