Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding nekonight color scheme #9051

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bgcicca
Copy link

@bgcicca bgcicca commented Feb 4, 2025

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is an a beautiful and inspiring color scheme with the potential to become a theme pack with regular updates.

As it is a color scheme package, it is expected that there will be packages similar to this one but without the same colors...

@bgcicca
Copy link
Author

bgcicca commented Feb 4, 2025

I'm going to add installation instructions to the original repository so that the pull request meets the necessary standards to be accepted

@bgcicca
Copy link
Author

bgcicca commented Feb 4, 2025

ready

@braver
Copy link
Collaborator

braver commented Feb 5, 2025

The convention is to put “color scheme” in the name of the package. Makes them easier to find. That’s not a hard requirement per se though.

You still need to tag the latest version of your package.

If you’re targeting Sublime Text specifically, you’ll want to convert it to the sublime-color-scheme format. That uses variables, and is much easier to edit and maintain. A tool is available in ST to do the conversion for you.

@bgcicca
Copy link
Author

bgcicca commented Feb 5, 2025

The convention is to put “color scheme” in the name of the package. Makes them easier to find. That’s not a hard requirement per se though.

You still need to tag the latest version of your package.

If you’re targeting Sublime Text specifically, you’ll want to convert it to the sublime-color-scheme format. That uses variables, and is much easier to edit and maintain. A tool is available in ST to do the conversion for you.

Ohh, ok, I'm on the street, but when I get home I'll switch to the sublime colorscheme format and refactor the pr so I don't get this lint error anymore, thanks for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants