Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hadar theme to h.json #9068

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cristianvasquezc
Copy link

@cristianvasquezc cristianvasquezc commented Mar 1, 2025

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • Any commands are available via the command palette.
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

There are no packages like it in Package Control.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Hadar Theme

Packages added:
  - Hadar Theme

Processing package "Hadar Theme"
  - All checks passed

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Hadar Theme

Packages added:
  - Hadar Theme

Processing package "Hadar Theme"
  - All checks passed

@braver
Copy link
Collaborator

braver commented Mar 7, 2025

Thanks for your submission, looks good. Not sure if I read your code correctly, but if this package installs other packages (A File Icon), then it would be good to explain that in the readme.

@braver braver added feedback provided mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side labels Mar 7, 2025
@cristianvasquezc
Copy link
Author

Thank you for your feedback! I've updated the README.md file to clearly explain that the theme installs additional packages, such as A File Icon, to enhance the user experience. Here's the updated section:

## III Additional Packages

Please note that this package installs additional packages to enhance the theme experience. One of these packages is `A File Icon`, which provides file specific icons for better visual identification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback provided mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants