Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better use WH logic & triggering #264

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

veniversum
Copy link

Resolves #254, #246

@veniversum veniversum changed the title Don't use WH if boss dead Better use WH logic & triggering Jun 18, 2015
@kaetemi
Copy link

kaetemi commented Jun 18, 2015

Sweet.

@blole
Copy link

blole commented Jun 18, 2015

triggerItem() needs to be changed to triggerAbility() to make the wormhole speedup work as intended, see #272 :)

Ideally only those with low starting number of wormholes should activate. Defaults to false.
@veniversum
Copy link
Author

New added wormhole logic to minimize wasted wormholes can now be toggled via checkbox at bottom of page.

Default value is false and option is only recommended to be enabled for new players with less starting wormholes than room average. (Could toggle automatically based on given value)

@koolkdev
Copy link

You are missing a hasItem check. Look on my pull request #279

@veniversum
Copy link
Author

@koolkdev Updated to include hasItem check

Resolved merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants