Add invalid variable service type for environments and pipelines #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and exit with error if found
…l entry. Add warn message, if there are any invalid entries on CM already
|
Hi @tobias-richter, thanks for this fix. I moved the check for an invalid service value outside the for loops and added some output, if there is an invalid value on the CM already. |
BerSomBen
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
the changes do what I expected, I improved the check a lil bit and added some output, if there is an invalid entry on the CM.
Please have a look and feel free to merge @tobias-richter
tobias-richter
commented
Oct 15, 2024
tobias-richter
merged commit c62bf75
into
feature/use-service-property-in-env-vars-patching
tobias-richter
deleted the
feature/use-service-property-in-env-vars-patching-resilience
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the resilience of #37 and ensure that