Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination support to domain list #46

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

tobias-richter
Copy link
Contributor

I noticed that the domain list only returns 20 domains.
I have now added --limit and --start arguments for domain list and increased the default limit to 1000

@BerSomBen
Copy link
Collaborator

I did some testing and am fine with this changes:

 domain list --start 10 --limit 10  | jq length  
10
 domain list  | jq length  
152
 domain list --start 100  | jq length  
53

@BerSomBen BerSomBen merged commit ff60e76 into main Oct 24, 2024
6 checks passed
@BerSomBen BerSomBen deleted the feature/add-start-limit-to-domain-call branch October 24, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants