Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new GraniteUI validator: wcmio.handler.media.mediaFormat #69

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

stefanseifert
Copy link
Member

@stefanseifert stefanseifert commented Sep 24, 2024

Add new GraniteUI validator wcmio.handler.media.mediaFormat which can be set on Media Handler File Upload or Path Field components to hook the media format validation into the GraniteUI dialog validation.

Example:

"mediaRef": {
  "sling:resourceType": "wcm-io/handler/media/components/granite/form/fileupload",
  "fieldLabel": "Asset reference",
  "validation": ["wcmio.handler.media.mediaFormat"]
}

Fixes #68

@srikanthgurram-17
Copy link

Hi @stefanseifert is there any ETA for this topic? we would like to use this feature going forward in our project. Thanks

@stefanseifert
Copy link
Member Author

with upcoming adaptTo() i have very little time currently, i plan to finish this in november

@srikanthgurram-17
Copy link

Hi @stefanseifert , any updates here?

@stefanseifert stefanseifert changed the title Hook Media Format validation into GraniteUI validation (optional) Add new GraniteUI validator: wcmio.handler.media.mediaFormat Nov 28, 2024
@stefanseifert stefanseifert marked this pull request as ready for review November 28, 2024 09:35
@wcm-io wcm-io deleted a comment from sonarqubecloud bot Nov 28, 2024
@stefanseifert
Copy link
Member Author

@srikanthgurram-17 it should work now if configured as described in the issue description.
can you give it a try?

@srikanthgurram-17
Copy link

@srikanthgurram-17 it should work now if configured as described in the issue description. can you give it a try?

@stefanseifert I verified in my local looks fine. Thanks

@stefanseifert stefanseifert merged commit 1969ba1 into develop Dec 2, 2024
7 checks passed
@stefanseifert stefanseifert deleted the feature/media-format-validation branch December 2, 2024 14:13
@stefanseifert
Copy link
Member Author

thanks for checking, i've merged it

@srikanthgurram-17
Copy link

srikanthgurram-17 commented Dec 5, 2024

HI @stefanseifert is there a plan to release this feature, I see the release of media handler not yet done. can we expect this soon ?

@stefanseifert
Copy link
Member Author

i will release it early next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants