update changelog, improve unit tests

wcm-io · Sep 9, 2024 · 89497b0 · 89497b0
1 parent c6730b7
commit 89497b0
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/changes.xml b/changes.xml
@@ -24,6 +24,9 @@
   <body>
 
     <release version="5.6.2" date="not released">
+      <action type="update" dev="jhoh" issue="50">
+        Add support for Rendition.getBinary() method.
+      </action>
       <action type="update" dev="sseifert">
         Update to latest OSGi Mock.
       </action>

diff --git a/core/src/main/java/io/wcm/testing/mock/aem/dam/MockRendition.java b/core/src/main/java/io/wcm/testing/mock/aem/dam/MockRendition.java
@@ -166,7 +166,7 @@ public void dispose() {
 
     @Override
     public @Nullable URI getURI(BinaryDownloadOptions downloadOptions) throws RepositoryException {
-      final String path = "https://blostore.local:12345/blostore/" + rendition.getPath();
+      final String path = "https://blostore.local/blostore/" + rendition.getPath();
       try {
         return new URI(path);
       }

diff --git a/core/src/test/java/io/wcm/testing/mock/aem/dam/MockRenditionTest.java b/core/src/test/java/io/wcm/testing/mock/aem/dam/MockRenditionTest.java
@@ -23,7 +23,9 @@
 import static org.junit.Assert.assertNotEquals;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertSame;
+import static org.junit.Assert.assertTrue;
 
+import javax.jcr.Binary;
 import javax.jcr.RepositoryException;
 
 import org.apache.jackrabbit.api.binary.BinaryDownload;
@@ -100,8 +102,14 @@ public void testAdaptTo() {
 
   @Test
   public void testBinaryDownload() throws RepositoryException {
-    BinaryDownload d = (BinaryDownload)rendition.getBinary();
-    assertNotNull(d.getURI(null));
+    Binary binary = rendition.getBinary();
+    assertNotNull(binary);
+    assertEquals(0L, binary.getSize());
+    assertNotNull(binary.getStream());
+
+    assertTrue(binary instanceof BinaryDownload);
+    assertEquals("https://blostore.local/blostore//content/dam/sample/portraits/scott_reynolds.jpg/jcr:content/renditions/original",
+        ((BinaryDownload)binary).getURI(null).toString());
   }
 
 }