Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make template optional #38

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

alexandru-stancioiu
Copy link
Contributor

@alexandru-stancioiu alexandru-stancioiu commented Apr 18, 2024

Template should be optional similar to real PageManager implementation.
This caused an inconvenience as Launches for Content Fragments do not a templatized page

Copy link
Member

@stefanseifert stefanseifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltgm - can you add a unit test to validate the page creation without template?

@stefanseifert stefanseifert merged commit edc0934 into wcm-io:develop Apr 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants