Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dazaev submitting my css mockup lab #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 73 additions & 0 deletions starter-code/css/main.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
*{
font-family: Lato, sans-serif;
}
body{
width: 90%;
border-left: solid rgba(173, 173, 173, 1) 5px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding values to the border property, you should specify in this order: width, style, color.

padding-left: 40px;
}
h1 a{
text-decoration: none;
color: #ffcb85;
}
h1 {
font-weight: 300;
font-size: 48px;
}
h2 {
font-weight: 400;
margin-top: -1em
}
nav a {
color: rgba(227, 227, 227, 1);
font-size: 20px;
padding: 0 6px;
}
h3 {
color: rgba(227, 227, 227, 1);
font-size: 35px;
font-weight: lighter;
padding-top: 2%;
}
h2 a{
text-decoration: none;
color: black;
font-weight: 300;
font-size: 30px;
}
img{
width: 630px;
}
p::first-letter{
color: rgba(227, 227, 227, 1);
font-size: 90px;
line-height: 70%;
float: left;
padding: 0 8px 8px 0;
}
p{
font-size: 17px;
}
h4 a{
text-decoration: none;
color: #ffcb85;
text-align: right;
padding-left: 80%;
}
article{
width: 59%;
border-bottom: solid rgba(227, 227, 227, 1) 2px;
}
footer{
padding-top: 7%;
color: rgba(227, 227, 227, 1);

}
footer nav a{
color: #ffcb85;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes you are setting the color with RGB, other times it's with hex code. Try to be consistent in what you choose so it's easier to identify colors that are the same.

padding-left: 1px;
font-size: 18px;
}
footer p::first-letter{
font-size: 25px;
}
2 changes: 1 addition & 1 deletion starter-code/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,4 @@ <h4><a href="#">Continues...</a></h4>
<p>&copy; 2015 Rugged Industries, Inc.</p>
</footer>
</body>
</html>
</html>