Homework_2 complete #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BritneyJo
reviewed
Sep 20, 2017
| } | ||
|
|
||
| header h1{ | ||
| font-family: 'Lato', sans-serif; |
There was a problem hiding this comment.
Since you set the font-family in the body above, you don't have to reset it here again.
|
|
||
| header nav a:first-child{ | ||
| color:#DDDDDD; | ||
| padding:20px 0 0 0; |
There was a problem hiding this comment.
Another way to write this since you're only adding padding to the left is padding-left: 20px;
| line-height: 1.5em; | ||
| } | ||
|
|
||
| article p::first-letter{ |
| font-size: 600%; | ||
| color: #DDDDDD; | ||
| float:left; | ||
| margin: .3em .1em .4em 0; |
There was a problem hiding this comment.
I like that you're trying out ems here! But make sure you are consistent in whatever you choose. So if you start off setting margins in ems, then stick with it throughout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.