Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finished css code #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

finished css code #15

wants to merge 1 commit into from

Conversation

chavandrew
Copy link

No description provided.

BritneyJo
BritneyJo reviewed Sep 20, 2017
View reviewed changes
Copy link

@BritneyJo BritneyJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to watch when repeating yourself in CSS. Anytime you've written the same property and value more than once, there is an opportunity to refactor and condense your code by comma separating those selectors.

starter-code/finished_css_code
@@ -0,0 +1,113 @@
*{
width: 850px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than using a px value, use a % for width or set margin/padding so you can keep your site responsive.

starter-code/finished_css_code
color: #FFC963;
font-size: 60px;
text-decoration-line: none;
font-family: sans-serif;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've already set the same font-family in the body so you don't need to set it again here.

starter-code/finished_css_code

h2 {
font-size: 30px;
font-family: sans-serif;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've already set the same font-family in the body so you don't need to set it again here.

starter-code/finished_css_code
}
h4 a{
color: #FFC963;
border-bottom: .9px solid #C3C3C3;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1px is pretty small already - I think .9px is a value that I probably would stray away from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BritneyJo BritneyJo BritneyJo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chavandrew @BritneyJo