-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rika CSS HWmy #18
base: master
Are you sure you want to change the base?
Rika CSS HWmy #18
Conversation
} | ||
|
||
article { | ||
max-width: 600%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you might be a bit confused on when to use %. Setting a max-width of 600% means that this article will be 6times as large as the full page or window. I'm pretty sure that's not what you meant to do here. Did you perhaps mean 60% so it only takes up a little over half the window?
article { | ||
max-width: 600%; | ||
padding: 50px; | ||
border-bottom: solid 2px rgb(231, 231, 226);; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Watch your typing - you have two ;; at the end of this line which could break the file.
font-weight: lighter; | ||
text-decoration: none; | ||
font-size: 30px; | ||
color: #292928; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be consistent in your color values. If you want to use hex codes, use them all the time, otherwise stick with rgb.
|
||
} | ||
|
||
h1 a, h4 a { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great selector choice here!!
span { | ||
float: left; | ||
width: 0.7em; | ||
font-size: 400%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is another area where I don't think you meant to use %. Font-sizes should usually be set in px, rem, or em.
view my hw