Raul Gutierrez Homework Pull #19
Conversation
| margin-left: 20px; | ||
| border-left-style: solid; | ||
| border-left-color: rgba(195,195,195,.8); | ||
|
|
There was a problem hiding this comment.
Typically when you are specifying border CSS, you want to set the width, style, and color. You can do that in one line: border-left: 10px solid rgba(195, 195, 195, .8);
|
|
||
| a{ | ||
| text-decoration: none; | ||
| all: unset; |
There was a problem hiding this comment.
Rather than using this CSS property, you will want to consider a normalize or reset css sheet instead.
| article{ | ||
| border-bottom-style: solid; | ||
| border-bottom-width: thin; | ||
| border-bottom-color: rgba(195,195,195,.8); |
There was a problem hiding this comment.
Combine these into one line: border-bottom: thin solid rgba(195,195,195,0.8);
| } | ||
|
|
||
| footer p{ | ||
| color: rgba(195,195,195,.8); |
There was a problem hiding this comment.
This color value is being set multiple times throughout the css file.. it would make more sense to set the entire body color to this once, or move selectors together to set the color at once. Whenever you start writing out the same property and value more than once, it's a good idea to think how you can adjust selectors to reduce that repetition.
No description provided.